Skip to content

doc: Clarify verbosity options #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Conversation

LecrisUT
Copy link
Collaborator

  • Changed cmake.verbose mention to build.verbose
  • Clarified that CMake configure output is always printed, and does not require any additional options. That's the main usage usually.

Comment on lines -71 to -77
:::{note}

When using `pip`, make sure you include at least a `-v` argument so that the
verbosity settings above are displayed.

:::

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this note gone? pip and uv pip hide all output by default. build and uv build do not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it to the top and made it more generic, didn't want to duplicate it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, it was rewritten at the top, didn't notice. Okay. I think the note helped it be a bit more called out, but that's fine.

@henryiii henryiii merged commit 29443d3 into scikit-build:main Mar 17, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants