Skip to content

tests: min constraints without Windows #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2022
Merged

tests: min constraints without Windows #129

merged 3 commits into from
Nov 22, 2022

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Nov 22, 2022

Pulled out of #126

  • Fix a few missing values for CMake 3.15 FileAPI
  • All FileAPI dataclasses now frozen
  • Correct wrong minimum for typing_extensions
  • Testing minimum requirements
  • Rich not required in testing anymore (bad capping practices!)

I am not using/constraining the CMake package since it's broken on macOS 13 until recently. This also means I can't test 3.15 easily locally, but due to ExeptionGroups printing all errors at once, I didn't have to iterate!

Also drop rich from test req due to capping

Signed-off-by: Henry Schreiner <[email protected]>

Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii enabled auto-merge (rebase) November 22, 2022 21:50
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #129 (d14e8dc) into main (60efaa5) will decrease coverage by 0.22%.
The diff coverage is 92.06%.

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   90.82%   90.60%   -0.23%     
==========================================
  Files          43       43              
  Lines        1712     1724      +12     
==========================================
+ Hits         1555     1562       +7     
- Misses        157      162       +5     
Impacted Files Coverage Δ
...rc/scikit_build_core/file_api/_cattrs_converter.py 93.87% <70.00%> (-6.13%) ⬇️
src/scikit_build_core/file_api/reply.py 84.93% <77.77%> (-1.84%) ⬇️
src/scikit_build_core/file_api/model/cache.py 100.00% <100.00%> (ø)
src/scikit_build_core/file_api/model/cmakefiles.py 100.00% <100.00%> (ø)
src/scikit_build_core/file_api/model/codemodel.py 100.00% <100.00%> (ø)
src/scikit_build_core/file_api/model/common.py 100.00% <100.00%> (ø)
src/scikit_build_core/file_api/model/directory.py 100.00% <100.00%> (ø)
src/scikit_build_core/file_api/model/index.py 100.00% <100.00%> (ø)
src/scikit_build_core/file_api/model/toolchains.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii henryiii merged commit 8b0aae7 into main Nov 22, 2022
@henryiii henryiii deleted the henryiii/tests/min0 branch November 22, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant