Skip to content

fix: EXT_SUFFIX wrong before 3.8.7 #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2022
Merged

fix: EXT_SUFFIX wrong before 3.8.7 #160

merged 3 commits into from
Dec 13, 2022

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Dec 13, 2022

This was fixed in CPython 3.8.7.

Would also be fixed by #148.

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/fix/extsuff branch from 49db28a to 80c4a30 Compare December 13, 2022 22:47
@henryiii henryiii enabled auto-merge (squash) December 13, 2022 23:06
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #160 (a9f18d0) into main (b9dc3d4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   90.48%   90.50%   +0.01%     
==========================================
  Files          44       44              
  Lines        1829     1832       +3     
==========================================
+ Hits         1655     1658       +3     
  Misses        174      174              
Impacted Files Coverage Δ
src/scikit_build_core/builder/builder.py 96.47% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii henryiii merged commit c18f38c into main Dec 13, 2022
@henryiii henryiii deleted the henryiii/fix/extsuff branch December 13, 2022 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant