Skip to content

docs: use modern cmake/ninja version setting in Fortran example #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

henryiii
Copy link
Collaborator

Fixing the example.

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.90%. Comparing base (9d49270) to head (c9ced82).
Report is 77 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #809   +/-   ##
=======================================
  Coverage   82.90%   82.90%           
=======================================
  Files          69       69           
  Lines        3926     3926           
=======================================
  Hits         3255     3255           
  Misses        671      671           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii henryiii merged commit 20f32fd into main Jul 14, 2024
51 checks passed
@henryiii henryiii deleted the henryiii/docs/modfortex branch July 14, 2024 05:15
@flex0902
Copy link

flex0902 commented Jul 21, 2024

The latest pysoild 0.3.3 using this example for compiling fortran program "solid.for".
when I use "pip install pysolid", the error message in cmake is below:
image
The problem seeems to be "\" in the path.
How do I solve this issue.
Many thanks

@henryiii
Copy link
Collaborator Author

We haven’t run this example on Windows (requires a Fortran compiler), so it looks like it’s missing a conversion to CMake path.

file(TO_CMAKE_PATH "${F2PY_INCLUDE_DIR}" F2PY_INCLUDE_DIR)

# or for CMake 3.20+ only
cmake_path(CONVERT ${F2PY_INCLUDE_DIR} TO_CMAKE_PATH_LIST F2PY_INCLUDE_DIR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants