Skip to content

fix: universal2 tags computation was incorrect #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

henryiii
Copy link
Collaborator

Was based on the wrong assumption for ARCHFLAGS.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #97 (09a62d4) into main (a163308) will decrease coverage by 0.03%.
The diff coverage is 87.50%.

❗ Current head 09a62d4 differs from pull request most recent head f13a23a. Consider uploading reports for the commit f13a23a to get more accurate results

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
- Coverage   90.95%   90.91%   -0.04%     
==========================================
  Files          44       44              
  Lines        1702     1707       +5     
==========================================
+ Hits         1548     1552       +4     
- Misses        154      155       +1     
Impacted Files Coverage Δ
src/scikit_build_core/builder/builder.py 86.86% <85.71%> (-0.37%) ⬇️
src/scikit_build_core/pyproject/wheel.py 92.59% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@henryiii henryiii enabled auto-merge (squash) November 17, 2022 04:51
@henryiii henryiii merged commit 9a661d6 into main Nov 17, 2022
@henryiii henryiii deleted the henryiii/fix/uni branch November 17, 2022 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant