feat: 0.11+ default to metadata 2.2 #986
Conversation
henryiii
force-pushed
the
henryiii/feat/metadata22
branch
from
5196bd2 to
190680b
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/metadata22
branch
from
190680b to
6fca630
Compare
| @@ -24,7 +24,8 @@ def test_wheel_writer_simple(tmp_path, monkeypatch): | |||
| "name": "something", | |||
| "version": "1.2.3", | |||
| }, | |||
| } | |||
| }, | |||
| metadata_version="2.3", | |||
There was a problem hiding this comment.
Well, it's explicitly testing that the manual override works, e.g. when manually setting it to 2.4 for the recent PEP639 support.
There was a problem hiding this comment.
Yeah, I just picked a random one here since this unit test doesn't include our manual "if 2.1" check. The one thing I didn't add is a check to see if it it still 2.1 if the minimum version is set below 0.11. If this had included our override, I'd have done that here.
There was a problem hiding this comment.
Also, related, I'm really thinking it might be safer to drop 3.7 support in 0.11 to go along with the default change, so 3.7 users don't have to worry about support for METADATA 2.2.
There was a problem hiding this comment.
I'll likely bring this up in today's developer meeting. :)
This has big performance benefits, and should be well supported now.