-
Notifications
You must be signed in to change notification settings - Fork 61
feat: Add new field build.requires
#992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we need And for sdist-building, I think we already have an override selector for that case? |
Yes. The question for this PR, is if we should provide a sane default if the user did not provide one, or we leave it completely to the user
Kind-of. The issue with [[tool.scikit-build.overrides]]
if.env.BUILD_ROOT = true
build.build-requires = ["foo @ file:${BUILD_ROOT}/foo"] and make sure |
I guess my question is, in what cases would this be incorrect? [[tool.scikit-build.overrides]]
if.from-sdist = false
build.build-requires = ["foo @ ./foo"]
[[tool.scikit-build.overrides]]
if.from-sdist = true
build.build-requires = ["foo"] |
$ pip install .
(this works fine assuming there is /foo)
$ cd bar && pip install ../
(this breaks because it is checking for /bar/foo) (don't we need to specify |
Okay, since we already use Python formatting in class DispPath(Path):
def __format__(self, fmt):
command, _, rest = fmt.partition(":")
if command == "parent":
return self.parent.__format__(rest)
if command == "uri" and rest == "":
return self.as_uri()
if command == "" and rest == "":
return str(self)
raise ... |
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
Signed-off-by: Cristian Le <[email protected]>
…roject.toml` (#998) Related to #992 formatter, I think it would be good to have a common place where to define all the format variables. Not sure on the implementation though if it should be a `TypedDict`, simple `Mapping` wrapper or anything else. --------- Signed-off-by: Cristian Le <[email protected]> Signed-off-by: Henry Schreiner <[email protected]> Co-authored-by: Henry Schreiner <[email protected]>
build.build-requires
build.requires
TODO:
build-system.requires
{root:uri}
hatchling
is added to dependency?Do we add a special case forPostponed because it would require a more involved process to validate.sdist
building or document that the user should define it?