-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[MRG] MAINT compatibility sklearn 0.20 -> wait for next release #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 98.74% 98.75% +0.01%
==========================================
Files 75 75
Lines 4543 4503 -40
==========================================
- Hits 4486 4447 -39
+ Misses 57 56 -1
Continue to review full report at Codecov.
|
This crashes all over the place, 'cos the CI's still install scikit-learn 0.19, should not we wait until release? Or at least pip install from master? |
It is not to be merge until we release in the same time than sklearn 0.20. What is important is that the build on sklearn master is passing.
|
bf1ec62
to
23ad602
Compare
Hello @glemaitre! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 04, 2018 at 15:01 Hours UTC |
Reference Issue
closes #371
What does this implement/fix? Explain your changes.
Any other comments?