-
Notifications
You must be signed in to change notification settings - Fork 1.3k
FEA allow any resampler in the BalancedBaggingClassifier #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEA allow any resampler in the BalancedBaggingClassifier #808
Conversation
I think that we need to be careful with the |
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
==========================================
- Coverage 98.59% 95.80% -2.79%
==========================================
Files 93 91 -2
Lines 6045 5959 -86
Branches 503 504 +1
==========================================
- Hits 5960 5709 -251
- Misses 84 192 +108
- Partials 1 58 +57
Continue to review full report at Codecov.
|
…neralized_sampler
…neralized_sampler
…neralized_sampler
Hello @glemaitre! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-02-18 11:24:39 UTC |
…neralized_sampler
closes #653
It allows implementing the following methods just by swapping the sampling:
TODO:
FunctionSampler
by bypassing thesampling_strategy
validation.