-
-
Notifications
You must be signed in to change notification settings - Fork 34
VOTE propose vote for SLEP007 #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+1 That will be a great addition to sklearn ! |
+1 as well |
+1 |
2 similar comments
+1 |
+1 |
Just to clarify: my approval for this PR stands for a +1 for the vote. |
+1 with minor adjustment to |
The SLEP says nothing of the types of the feature names (str vs other) or the collection of them (list vs array). Should it? Otherwise, I'm happy with this. (I have wondered, however, whether we give ourselves headaches by trying to ascribe names, rather than objects with structure and behaviour, to the representation of features. But certainly, we'd be giving ourselves more headaches if we wanted to attach such structured objects to DataFrames!) |
This is probably something that we should clarify by amending the current proposal as done there: #59 (comment) |
Opened #61 to add more details regarding the container, dtype, and strings. |
The vote has been open for a month and a consensus has been reached. We can provide post-history changes to give more details and improve the current proposal. ping @adrinjalali @thomasjpfan did I miss anything in the process? I let you review and merge this PR if everything is OK. |
I agree, and I think we've gone forward with the implementation and we seem to have a good consensus now. |
In this PR, I propose a vote for SLEP007.
As per our governance, the vote will last 1 month and will be announced shortly on the internal mailing list. We will seek a consensus during this month. If no consensus is found, the decision will be escalated to the Technical Committee (TC).