Skip to content

ENH Adds the details about the numpy arrays and strings #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions slep007/proposal.rst
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,19 @@ Input Feature Names
The input feature names are stored in a fitted estimator in a
``feature_names_in_`` attribute, and are taken from the given input data, for
instance a ``pandas`` data frame. This attribute will be ``None`` if the input
provides no feature names.
provides no feature names. The ``feature_names_in_`` attribute is a 1d NumPy
array with object dtype and all elements in the array are strings.

Output Feature Names
####################

A fitted estimator exposes the output feature names through the
``get_feature_names_out`` method. Here we discuss more in detail how these
feature names are generated. Since for most estimators there are multiple ways
to generate feature names, this SLEP does not intend to define how exactly
feature names are generated for all of them. It is instead a guideline on how
they could generally be generated.
``get_feature_names_out`` method. The output of ``get_feature_names_out`` is a
1d NumPy array with object dtype and all elements in the array are strings. Here
we discuss more in detail how these feature names are generated. Since for most
estimators there are multiple ways to generate feature names, this SLEP does not
intend to define how exactly feature names are generated for all of them. It is
instead a guideline on how they could generally be generated.

As detailed bellow, some generated output features names are the same or a
derived from the input feature names. In such cases, if no input feature names
Expand Down