Skip to content

Show all imagestreams in imagestream file #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2024
Merged

Show all imagestreams in imagestream file #372

merged 4 commits into from
Jun 3, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented May 27, 2024

This pull request shows all tags in all imagestream json files.

It replaces this pull request #256

@phracek phracek mentioned this pull request May 27, 2024
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems May 27, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems May 28, 2024
View reviewed changes
@phracek phracek force-pushed the show_all_is branch 2 times, most recently from 7a20c43 to 1a80a09 Compare May 28, 2024 08:20
@phracek
Copy link
Member Author

phracek commented May 28, 2024

In real usecase, I tested it on postgresql-container.

python3 /root/postgresql-container/test/show_all_imagestreams.py
Tags in the image stream imagestreams/postgresql-centos.json:
- 10-el8 -> quay.io/sclorg/postgresql-10-c8s:latest
- 12-el8 -> quay.io/sclorg/postgresql-12-c8s:latest
- 13-el8 -> quay.io/sclorg/postgresql-13-c8s:latest
- 15-el8 -> quay.io/sclorg/postgresql-15-c8s:latest
- 13-el9 -> quay.io/sclorg/postgresql-13-c9s:latest
- 15-el9 -> quay.io/sclorg/postgresql-15-c9s:latest
- 16-el9 -> quay.io/sclorg/postgresql-16-c9s:latest
- latest -> 16-el9
Tags in the image stream imagestreams/postgresql-rhel-aarch64.json:
- 10-el8 -> registry.redhat.io/rhel8/postgresql-10:latest
- 12-el8 -> registry.redhat.io/rhel8/postgresql-12:latest
- 13-el8 -> registry.redhat.io/rhel8/postgresql-13:latest
- 15-el8 -> registry.redhat.io/rhel8/postgresql-15:latest
- 13-el9 -> registry.redhat.io/rhel9/postgresql-13:latest
- 15-el9 -> registry.redhat.io/rhel9/postgresql-15:latest
- 16-el9 -> registry.redhat.io/rhel9/postgresql-16:latest
- latest -> 16-el9
Tags in the image stream imagestreams/postgresql-rhel.json:
- 10-el7 -> registry.redhat.io/rhscl/postgresql-10-rhel7:latest
- 12-el7 -> registry.redhat.io/rhscl/postgresql-12-rhel7:latest
- 13-el7 -> registry.redhat.io/rhscl/postgresql-13-rhel7:latest
- 10-el8 -> registry.redhat.io/rhel8/postgresql-10:latest
- 12-el8 -> registry.redhat.io/rhel8/postgresql-12:latest
- 13-el8 -> registry.redhat.io/rhel8/postgresql-13:latest
- 15-el8 -> registry.redhat.io/rhel8/postgresql-15:latest
- 13-el9 -> registry.redhat.io/rhel9/postgresql-13:latest
- 15-el9 -> registry.redhat.io/rhel9/postgresql-15:latest
- 16-el9 -> registry.redhat.io/rhel9/postgresql-16:latest
- latest -> 16-el9

@phracek
Show all imagestreams in imagestream file
d87f08b 
New Python function is created so the imagestreams
are shown always.

This fixes PR #256

Signed-off-by: Petr "Stone" Hracek <[email protected]>
zmiklank
zmiklank reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Please see my comments.

phracek added 2 commits May 31, 2024 09:39
@phracek
Update test output text for better understanding
1903527 
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Fix pre-commit issues
8ab5c55 
Signed-off-by: Petr "Stone" Hracek <[email protected]>
@phracek
Copy link
Member Author

phracek commented May 31, 2024

[test]

zmiklank
zmiklank reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@zmiklank zmiklank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing, otherwise LGTM, thanks.

@phracek phracek merged commit 8c310e1 into master Jun 3, 2024
2 checks passed
@phracek phracek deleted the show_all_is branch June 3, 2024 08:08
@zmiklank
Copy link
Contributor

zmiklank commented Jun 3, 2024

@phracek In that case we can also remove "import sys".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmiklank zmiklank zmiklank left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phracek @zmiklank