Skip to content

test-libs: add the ability to set ImageStream name and tag #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2017
Merged

test-libs: add the ability to set ImageStream name and tag #44

merged 1 commit into from
Dec 4, 2017

Conversation

pkubatrh
Copy link
Member

@pkubatrh pkubatrh commented Dec 4, 2017

@pkubatrh
Copy link
Member Author

pkubatrh commented Dec 4, 2017

@praiskup @omron93 ptal

@praiskup
Copy link
Contributor

praiskup commented Dec 4, 2017 •
edited
Loading

Could we fix the method's documentation (it takes optionally two arguments now)?

@pkubatrh
Copy link
Member Author

pkubatrh commented Dec 4, 2017

Fixed, thanks!

@praiskup
Copy link
Contributor

praiskup commented Dec 4, 2017

I'm not terribly familiar with these testing concepts, but merging. Thank you.

@praiskup praiskup merged commit 7ffcd4f into sclorg:master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkubatrh @praiskup