Skip to content

Make rails-ex work with Ruby 3.3 #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

pvalena
Copy link
Member

@pvalena pvalena commented Jan 17, 2024

I have managed to make it work with Ruby 3.3!

It works with all the other Ruby versions as well. Test log:
https://gist.github.com/pvalena/6834136128fb4fb131da6d779416831d

Ruby 3.3 PR & logs:: sclorg/s2i-ruby-container#507

@pvalena
Copy link
Member Author

pvalena commented Jan 17, 2024

@jackorp PTAL.

@phracek
Copy link
Member

phracek commented Jan 19, 2024

@pvalena Will this change work also with the older ruby versions? If not what about to branch it?

@pvalena
Copy link
Member Author

pvalena commented Jan 19, 2024

@phracek
Yes, it works with ALL Ruby versions we have additionally to Ruby 3.3. No branching needed. Test logs proving that are in the initial comment.

@pvalena pvalena self-assigned this Jan 19, 2024
@jackorp
Copy link
Collaborator

jackorp commented Jan 19, 2024

@phracek The app should be OK as long as this set of dependencies is not tested on RHEL 7 (or RHEL 7 based containers for that matter) due to the incompatibility between the system postgresql version and the newer rubygem-pg database connector. If we still need/want to test against RHEL 7, only then I think branching out is needed.

@pvalena
Copy link
Member Author

pvalena commented Jan 31, 2024

Can we merge this? Is anything else needed from my side?

@jackorp
Copy link
Collaborator

jackorp commented Jan 31, 2024

@pvalena testing the rails-ex with RHEL 7 is still expected and required. Your current gemfile will not work because rubygem-pg with version this high does not work with Postgres (or probably even compile) that is default on RHEL 7. That is why a new branch is needed and we cannot do this refresh on master.

@pvalena
Copy link
Member Author

pvalena commented Jan 31, 2024

Oh, and can't we create a branch for RHEL-7 instead?

@jackorp
Copy link
Collaborator

jackorp commented Jan 31, 2024

If I recall correctly my last discussion with @phracek about this, the preferred way is to have a branch for 3.3 onward rather than the inverse.

@pvalena
Copy link
Member Author

pvalena commented Jan 31, 2024

Ok then - or can't version/tag suffice? Do we expect any updates will be needed for RHEL-7 further on?
If not, can you create the branch and I'll move the PR target there.

@pvalena pvalena closed this Feb 12, 2024
@pvalena pvalena mentioned this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants