remove template prefix from tsb annotations #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparees
force-pushed
the
annotations
branch
4 times, most recently
from
4514640 to
c022418
Compare
bparees
commented
Oct 19, 2017
| "annotations": { | ||
| "template.openshift.io/expose-username": "{.data['application-user']}", | ||
| "template.openshift.io/expose-password": "{.data['application-password']}" | ||
| } |
There was a problem hiding this comment.
@jim-minter ptal, we don't have the db creds exposed in our other example templates so i'm inclined to remove it here for consistency...are you aware of any reason why this one had it but the others do not?
There was a problem hiding this comment.
an aberration on my part, I think; removing it is fine by me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.