Test with rails-ex on branch 3.3 going forward. #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @phracek I hope I remembered correctly from our meetings that the new rails-ex branch will be the new de-facto default. Not sure, do some openshift tests somewhere also need similar adjusting? |
Merged
pvalena
reviewed
Feb 19, 2024
pvalena
approved these changes
Feb 19, 2024
rails-ex for Ruby 3.3 needs updated dependencies but that's not possible as RHEL 7 requires pg <= 1.2.3 due to the old PostgreSQL available. Therefore, by default we'll use [email protected] for tests, older rubies such as 3.1 or 2.5 will keep using the rails-ex@master.
jackorp
force-pushed
the
update-rails-ex-for-tests
branch
from
1116158 to
585d187
Compare
|
@pvalena PTAL for bash. I used a function to cut down on repetition in the Openshift tests. I think we want to differentiate the remote ref in all openshift tests due to the Rails app dependency changes. And I think it'd be a good idea to run tests with this to validate I didn't make behavior changes for the current state before inclusion of Ruby 3.3 @phracek |
|
[test-all] |
phracek
pushed a commit
to pvalena/s2i-ruby-container
that referenced
this pull request
Feb 22, 2024
* Test with rails-ex on branch 3.3 going forward. rails-ex for Ruby 3.3 needs updated dependencies but that's not possible as RHEL 7 requires pg <= 1.2.3 due to the old PostgreSQL available. Therefore, by default we'll use [email protected] for tests, older rubies such as 3.1 or 2.5 will keep using the rails-ex@master. * Use rails-ex ref 3.3 when testing with Ruby 3.3 and newer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails-ex for Ruby 3.3 needs updated dependencies
but that's not possible as RHEL 7 requires pg <= 1.2.3 due to the old PostgreSQL available. Therefore, by default we'll use [email protected] for tests, older rubies such as 3.1 or 2.5 will keep using the rails-ex@master.