Adding basic_auth support

[ericabouaf]

Hi,

My Wordpress installation is protected by a Basic Authentication, so here is a fix to support Basic Auth.

Cheers,

[scottgonzalez]

Please rename the option to basicAuth.

[staabm]

the key basic_auth is defined in https://github.com/baalexander/node-xmlrpc/blob/master/lib/client.js#L61 so cannot be changed.

[staabm]

oh you mean the key we use in our side of the config..

[staabm]

btw... there are some more "misnamed" options in the game. as it stands right now, even when using basicAuth as a key the config would look like

{
    "url": "https://example.com/",
    "username": "test123",
    "password": "xdsfadsf",
    "basicAuth": {
        "user": "testr5z57",
        "pass": "asdfadsf"
    }
}

so username vs. user
and password vs. pass

[staabm]

to avoid the name mismatch I would suggest using

// ....
    this.rpc = xmlrpc[ parsedUrl.secure ? "createSecureClient" : "createClient" ]({
        host: settings.host || parsedUrl.host,
        port: parsedUrl.port,
        path: parsedUrl.path,

        // Always set Host header in case we're pointing to a different server
        // via settings.host
        headers: {
            Host: parsedUrl.host
        },
        basic_auth: settings.basicAuth ? {
            user: settings.basicAuth.username,
            pass: settings.basicAuth.password
        } : null,
    });
// ....

[staabm]

submitted #47

[staabm]

also need support for basic auth... so +1