Skip to content

Close opened sources files after reading them #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2021
Merged

Close opened sources files after reading them #372

merged 1 commit into from
Sep 15, 2021

Conversation

lefou
Copy link
Contributor

@lefou lefou commented Sep 15, 2021

Fix #371

ckipp01
ckipp01 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah you beat me to it. Thanks a lot for finding and sending this in @lefou!

@ckipp01 ckipp01 merged commit 2254d59 into scoverage:main Sep 15, 2021
@ckipp01
Copy link
Member

ckipp01 commented Sep 15, 2021

I'd like to get #370 merged in as well and then there will be a new release.

@lefou lefou deleted the close-files branch September 15, 2021 12:27
ckipp01 pushed a commit that referenced this pull request Sep 23, 2021
@lefou @ckipp01
Close opened sources files after reading them (#372)
e31cc35 
Fix #371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckipp01 ckipp01 ckipp01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scoverage does not close source files after reading
2 participants
@lefou @ckipp01