Fixed two minor bugs in the helpers #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
Great work you're doing with the declarations, really appreciated! Keep it up! 👍
I migrated to the #TS2 branch, and only two things broke on my part, both of which I monkey patched previously on my own copy. I do believe both patches are valid though, so here goes:
#1 : A PathFinder
roomCallback
(which is dubbedcostCallback
inFindPathOpts
) can returnfalse
if a room is not to be searched.path-finder.ts
already has the correct return value, but theFindPathOpts
helper did not. See http://support.screeps.com/hc/en-us/articles/207023879-PathFinder#search for the docs on the callback. I quote:Thanks!