Skip to content

deprecate scvi #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 9, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
python -m pip install --upgrade pip
pip install -r .pip-2033.txt
pip install pytest-cov wheel
pip install .[dev,doc,test,louvain,leiden,magic,scvi,harmony,scrublet,scanorama]
pip install .[dev,doc,test,louvain,leiden,magic,harmony,scrublet,scanorama,skmisc]
displayName: 'Install dependencies'

- script: |
Expand Down
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ matrix:
- name: "anndata dev"
python: "3.7"
install:
- pip install .[dev,test,louvain,leiden,magic,scvi,harmony,skmisc,scrublet,scanorama]
- pip install .[dev,test,louvain,leiden,magic,harmony,skmisc,scrublet,scanorama]
- pip install git+https://github.com/theislab/anndata
python:
- '3.6'
Expand All @@ -27,7 +27,7 @@ cache:
- directories:
- data
install:
- pip install .[dev,test,louvain,leiden,magic,scvi,harmony,skmisc,scrublet,scanorama]
- pip install .[dev,test,louvain,leiden,magic,harmony,skmisc,scrublet,scanorama]
env:
- MPLBACKEND=Agg
script:
Expand Down
3 changes: 1 addition & 2 deletions docs/release-notes/1.5.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The `1.5.0` release adds a lot of new functionality, much of which takes advanta

.. rubric:: External tools

- :func:`~scanpy.external.pp.scvi` for preprocessing with scVI :pr:`1085` :smaller:`G Xing`
- `scanpy.external.pp.scvi` for preprocessing with scVI :pr:`1085` :smaller:`G Xing`
- Guide for using :ref:`Scanpy in R <conversion_to_r>` :pr:`1186` :smaller:`L Zappia`

.. rubric:: Performance
Expand Down Expand Up @@ -48,4 +48,3 @@ The `1.5.0` release adds a lot of new functionality, much of which takes advanta
- :func:`~scanpy.tl.louvain` for Louvain `0.6` :pr:`1197` :smaller:`I Virshup`
- :func:`~scanpy.pp.highly_variable_genes` which could lead to incorrect results when the `batch_key` argument was used :pr:`1180` :smaller:`G Eraslan`
- :func:`~scanpy.tl.ingest` where an inconsistent number of neighbors was used :pr:`1111` :smaller:`S Rybakov`

2 changes: 1 addition & 1 deletion docs/release-notes/1.7.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
- Updates for :func:`~scanpy.external.tl.palantir` and :func:`~scanpy.external.tl.palantir_results` :pr:`1245` :smaller:`A Mousa`
- Fixes to :func:`~scanpy.external.tl.harmony_timeseries` docs :pr:`1248` :smaller:`A Mousa`
- Support for `leiden` clustering by :func:`scanpy.external.tl.phenograph` :pr:`1080` :smaller:`A Mousa`
- Deprecate :func:`~scanpy.external.pp.scvi` :pr:`1554` :smaller:`G Xing`
- Deprecate `scanpy.external.pp.scvi` :pr:`1554` :smaller:`G Xing`
- Updated default params of :func:`~scanpy.external.tl.sam` to work with larger data :pr:`1540` :smaller:`A Tarashansky`

.. rubric:: Documentation
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ requires = [
louvain = ['python-igraph', 'louvain>=0.6,!=0.6.2']
leiden = ['python-igraph', 'leidenalg']
bbknn = ['bbknn']
scvi = ['scvi==0.6.7']
rapids = ['cudf>=0.9', 'cuml>=0.9', 'cugraph>=0.9']
magic = ['magic-impute>=2.0']
skmisc = ['scikit-misc>=0.1.3']
Expand Down
1 change: 0 additions & 1 deletion scanpy/external/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@

pp.dca
pp.magic
pp.scvi


Tools: TL
Expand Down
1 change: 0 additions & 1 deletion scanpy/external/pp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@
from ._harmony_integrate import harmony_integrate
from ._magic import magic
from ._scanorama_integrate import scanorama_integrate
from ._scvi import scvi
from ._hashsolo import hashsolo
from ._scrublet import scrublet, scrublet_simulate_doublets
210 changes: 0 additions & 210 deletions scanpy/external/pp/_scvi.py

This file was deleted.

61 changes: 0 additions & 61 deletions scanpy/tests/external/test_scvi.py

This file was deleted.