exec_profile: Use cluster lbp for exec profiles by default #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorak-mmk
requested changes
Oct 21, 2024
muzarski
force-pushed
the
use-cluster-lbp-for-exec-profiles-by-default
branch
2 times, most recently
from
ab0950b to
a23ebac
Compare
|
v2: Reverted the changes introduced by |
muzarski
force-pushed
the
use-cluster-lbp-for-exec-profiles-by-default
branch
from
a23ebac to
5eaa9e2
Compare
|
v3: Rebased on #200. Addressed all of @Lorak-mmk comments |
Lorak-mmk
approved these changes
Oct 30, 2024
`self` is consumed by this method, thus there is no need to match dc_awareness by reference and to clone a local_dc string.
Introduced for multiple reasons: - rack awareness will be introduced soon - preparation for another refactor in next commit.
In this commit, we make `load_balancing_kind` optional in `LoadBalancingConfig`. Now, there are two cases: - for cluster's LBP, there is a default value (round-robin) which driver's going to use if user did not provide LBP. Thus, the `unwrap_or` call in `LoadBalancingConfig::build` - for exec profile's LBP, if user did not provide an LBP kind (load_balancing_kind is None), then, according to cpp-driver, cluster's LBP should be used (instead of some predefined default). After this commit, we are finally consistent with cpp-driver. Now, if user did not specify an LBP for given execution profile, the cluster's default LBP (session-wide LBP) will be assigned to the profile.
muzarski
force-pushed
the
use-cluster-lbp-for-exec-profiles-by-default
branch
from
5eaa9e2 to
dea239a
Compare
|
Rebased on master |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of
cass_execution_profile_set_load_balance_...functions states:It seems to be true, see: https://github.com/scylladb/cpp-driver/blob/master/src/request_processor.cpp#L196-L209.
We should adjust cpp-rust-driver so it behaves the same way.
This PR consist mostly of some refactor commits that prepare for the logic change in the last commit.
Pre-review checklist
[ ] I have implemented Rust unit tests for the features/changes introduced.[ ] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[ ] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.