Skip to content

update travis file #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2014
Merged

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Oct 19, 2014

  • install deps in install section
  • no need to self-update the composer
  • install deps using travis_retry

- composer self-update
- composer install --no-interaction --prefer-source --dev
install:
- travis_retry composer install --no-interaction --prefer-source --dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also ditch the --dev at this point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah ;)

@GrahamCampbell
Copy link
Contributor

👍

@sebastianbergmann
Copy link
Owner

Is this some new best practice with regards to Composer and Travis?

@GrahamCampbell
Copy link
Contributor

Yes. Symfony do something similar too.

@GrahamCampbell
Copy link
Contributor

And laravel will do the same very shortly.

sebastianbergmann added a commit that referenced this pull request Oct 19, 2014
@sebastianbergmann sebastianbergmann merged commit 92d423d into sebastianbergmann:master Oct 19, 2014
@keradus keradus deleted the travis branch October 19, 2014 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants