Skip to content

Minor Tweaks #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2014
Merged

Minor Tweaks #9

merged 2 commits into from
Feb 16, 2014

Conversation

GrahamCampbell
Copy link
Contributor

Whitespace and travis.

sebastianbergmann added a commit that referenced this pull request Feb 16, 2014
@sebastianbergmann sebastianbergmann merged commit ecc9239 into sebastianbergmann:master Feb 16, 2014
@whatthejeff
Copy link
Collaborator

@sebastianbergmann @GrahamCampbell Just to be clear, why are these changes needed for the composer command?

@GrahamCampbell
Copy link
Contributor Author

They make sure composer is running at the latest version, then they make sure composer doesn't ask for user input during an install, which would result in travis hanging until build timeout which is something like 40 mins.

@whatthejeff
Copy link
Collaborator

@GrahamCampbell Do we have an example where this has been a problem?

Also, isn't --dev on by default?

@GrahamCampbell
Copy link
Contributor Author

Yes it is, but it's nice to be explicit, even though it is not really necessary.

@whatthejeff
Copy link
Collaborator

@GrahamCampbell @sebastianbergmann I don't really see much value in adding extra commands/options when (as far as I know) we've never had an issue with the current command in any of the PHPUnit projects.

@whatthejeff
Copy link
Collaborator

Also, we might actually want to enable travis for this project @sebastianbergmann :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants