Skip to content

Factory should use canonical directory names #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-d opened this issue Nov 19, 2017 · 0 comments
Closed

Factory should use canonical directory names #34

j-d opened this issue Nov 19, 2017 · 0 comments

Comments

@j-d
Copy link
Contributor

j-d commented Nov 19, 2017

I had a performance issue with PHPUnit today. It was related to code coverage and folders that are excluded. This is the relevant section from my phpunit.xml file:

    <filter>
        <whitelist>
            <directory>.</directory>
            <exclude>
                <directory>vendor</directory>
            </exclude>
        </whitelist>
    </filter>

Changing vendor to ./vendor causes a considerable performance increase.

Factory should use canonical names so it can properly exclude folders. Alternatively, the documentation could be improved to account for this scenario.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant