Issue#2591no2 #2664

ArturGoldyn · 2017-04-29T19:57:04Z

Use @runClassInSeparateProcess annotation on test class to allow running a test class with process isolation.

…al state.

… all test methods running in the same process.

…a separate process.

codecov-io · 2017-04-30T20:11:50Z

Codecov Report

Merging #2664 into master will increase coverage by 1.54%.
The diff coverage is 77.55%.

@@             Coverage Diff             @@
##             master   #2664      +/-   ##
===========================================
+ Coverage     53.85%   55.4%   +1.54%     
- Complexity     2745    2756      +11     
===========================================
  Files           102     102              
  Lines          7193    7218      +25     
===========================================
+ Hits           3874    3999     +125     
+ Misses         3319    3219     -100

Impacted Files	Coverage Δ	Complexity Δ
src/Framework/TestSuite.php	`71.62% <57.14%> (+1.11%)`	`151 <0> (+2)`	⬆️
src/Framework/TestCase.php	`56% <80%> (+1.24%)`	`303 <3> (+7)`	⬆️
src/Util/Test.php	`88.42% <85.71%> (+0.16%)`	`194 <2> (+2)`	⬆️
src/Util/Configuration.php	`84.26% <0%> (+0.43%)`	`157% <0%> (ø)`	⬇️
src/Framework/TestResult.php	`48.71% <0%> (+0.93%)`	`176% <0%> (ø)`	⬇️
src/Framework/Constraint/IsEqual.php	`92.15% <0%> (+1.96%)`	`13% <0%> (ø)`	⬇️
src/Framework/Constraint/JsonMatches.php	`91.11% <0%> (+2.22%)`	`14% <0%> (ø)`	⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3c42c...8169eb9. Read the comment docs.

sebastianbergmann · 2017-05-11T09:23:21Z

src/Util/PHP/Template/TestCaseMethod.tpl.dist

@@ -47,7 +47,12 @@ function __phpunit_run_isolated_test()
    $result->beStrictAboutTodoAnnotatedTests({isStrictAboutTodoAnnotatedTests});
    $result->beStrictAboutResourceUsageDuringSmallTests({isStrictAboutResourceUsageDuringSmallTests});

-    $test = new {className}('{methodName}', unserialize('{data}'), '{dataName}');


Would it make sense to use a new, separate template here? Maybe TestCaseClass.tpl.dist.

Of course, I think so, especially that I've just made changes to TestCaseMethod file.

sebastianbergmann · 2017-05-11T09:23:47Z

src/Framework/TestCase.php

+     *
+     * @var bool
+     */
+    protected $runClassInSeparateProcess;


Following the minimal visibility principle, this should be private.

I'll try that.

…cted." This reverts commit c4e670e.

ArturGoldyn · 2017-05-21T22:25:41Z

This fails now, probably due to change in sebastian/diff package from 1.4.1 to 1.4.2 https://github.com/sebastianbergmann/diff/

stickler-ci · 2017-05-30T22:33:54Z

src/Framework/TestCase.php

-                __DIR__ . '/../Util/PHP/Template/TestCaseMethod.tpl'
-            );
+            if ($runEntireClass) {
+	            $template = new Text_Template(


Spaces must be used to indent lines; tabs are not allowed

stickler-ci · 2017-05-30T22:33:55Z

src/Framework/TestCase.php

-            );
+            if ($runEntireClass) {
+	            $template = new Text_Template(
+	                __DIR__ . '/../Util/PHP/Template/TestCaseClass.tpl'


Spaces must be used to indent lines; tabs are not allowed

stickler-ci · 2017-05-30T22:33:55Z

src/Framework/TestCase.php

+            if ($runEntireClass) {
+	            $template = new Text_Template(
+	                __DIR__ . '/../Util/PHP/Template/TestCaseClass.tpl'
+	            );


Spaces must be used to indent lines; tabs are not allowed

ArturGoldyn · 2017-05-31T08:30:33Z

@sebastianbergmann template added, variable access changed, and all tests passing.

sebastianbergmann · 2017-06-01T07:34:56Z

Thanks!

KintradimCrux · 2017-07-02T21:07:35Z

In the current 6.2 release the method TestSuite::createTest() only calls $_test->setRunClassInSeparateProcess() for tests with a data provider.
Can you add this initialization for tests without a data provider, too?

KintradimCrux · 2017-07-02T22:25:19Z

And the @beforeClass, @afterclass, setUp() and tearDown() methods maybe should be called only in the isolated environment running the class.

sebastianbergmann · 2017-07-03T06:39:12Z

@KintradimCrux Can you please open tickets for these bugs? Thanks!

ArturGoldyn added 3 commits April 23, 2017 20:37

Issue #2591 - test process isolation with and without preserving glob…

1afe321

…al state.

Issue #2591 - allow test classes to be run in process isolation, with…

83b34d5

… all test methods running in the same process.

php-cs-fixer for my changes

172bab7

This was referenced Apr 29, 2017

Issue#2591 #2663

Closed

Run a class in separate process. #2591

Closed

Issue #2591 - do not pass methodName if running entire test class in …

746ab44

…a separate process.

Issue#2591 Do not use slash in path to pass test in Windows.

a3b5ed3

sebastianbergmann reviewed May 11, 2017

View reviewed changes

sebastianbergmann added the type/enhancement A new idea that should be implemented label May 11, 2017

sebastianbergmann added this to the PHPUnit 6.2 milestone May 11, 2017

ArturGoldyn added 2 commits May 21, 2017 23:21

Private variable $runClassInSeparateProcess, instead of protected.

c4e670e

Revert "Private variable $runClassInSeparateProcess, instead of prote…

298838d

…cted." This reverts commit c4e670e.

ArturGoldyn mentioned this pull request May 23, 2017

Difference or bug in 1.4.2 makes phpunit fail. sebastianbergmann/diff#44

Closed

ArturGoldyn added 3 commits May 30, 2017 23:21

Merge remote-tracking branch 'upstream/master' into Issue#2591no2

e1f4ad9

Private variable $runClassInSeparateProcess, instead of protected.

24237a7

"TestCaseClass" template for testing entire class in isolation.

0db068f

stickler-ci reviewed May 30, 2017

View reviewed changes

Update TetCase.php to pass linter.

8169eb9

sebastianbergmann merged commit abf3c61 into sebastianbergmann:master Jun 1, 2017

sebastianbergmann self-assigned this Jun 1, 2017

ArturGoldyn deleted the Issue#2591no2 branch June 1, 2017 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Issue#2591no2 #2664

Issue#2591no2 #2664

Uh oh!

ArturGoldyn commented Apr 29, 2017

Uh oh!

codecov-io commented Apr 30, 2017 •

edited

Loading

Uh oh!

sebastianbergmann May 11, 2017

Uh oh!

ArturGoldyn May 16, 2017

Uh oh!

sebastianbergmann May 11, 2017

Uh oh!

ArturGoldyn May 16, 2017

Uh oh!

ArturGoldyn commented May 21, 2017 •

edited

Loading

Uh oh!

stickler-ci May 30, 2017

Uh oh!

stickler-ci May 30, 2017

Uh oh!

stickler-ci May 30, 2017

Uh oh!

ArturGoldyn commented May 31, 2017

Uh oh!

sebastianbergmann commented Jun 1, 2017

Uh oh!

KintradimCrux commented Jul 2, 2017

Uh oh!

KintradimCrux commented Jul 2, 2017

Uh oh!

sebastianbergmann commented Jul 3, 2017

Uh oh!

Uh oh!

Uh oh!

Issue#2591no2 #2664

Issue#2591no2 #2664

Uh oh!

Conversation

ArturGoldyn commented Apr 29, 2017

Uh oh!

codecov-io commented Apr 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sebastianbergmann May 11, 2017

Choose a reason for hiding this comment

Uh oh!

ArturGoldyn May 16, 2017

Choose a reason for hiding this comment

Uh oh!

sebastianbergmann May 11, 2017

Choose a reason for hiding this comment

Uh oh!

ArturGoldyn May 16, 2017

Choose a reason for hiding this comment

Uh oh!

ArturGoldyn commented May 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stickler-ci May 30, 2017

Choose a reason for hiding this comment

Uh oh!

stickler-ci May 30, 2017

Choose a reason for hiding this comment

Uh oh!

stickler-ci May 30, 2017

Choose a reason for hiding this comment

Uh oh!

ArturGoldyn commented May 31, 2017

Uh oh!

sebastianbergmann commented Jun 1, 2017

Uh oh!

KintradimCrux commented Jul 2, 2017

Uh oh!

KintradimCrux commented Jul 2, 2017

Uh oh!

sebastianbergmann commented Jul 3, 2017

Uh oh!

Uh oh!

codecov-io commented Apr 30, 2017 •

edited

Loading

ArturGoldyn commented May 21, 2017 •

edited

Loading