Skip to content

Fix payload_len calculation for DataPacket. #4545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Splinter1984
Copy link

@Splinter1984 Splinter1984 commented Oct 1, 2024

This PR fix pl_len calculation issue for DataPacket of RTPS protocol.
Take into account the size of inlineQoS during payload length calculation.
Closes #4594

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.30%. Comparing base (6f0faf3) to head (998851c).
Report is 107 commits behind head on master.

Files with missing lines Patch % Lines
scapy/contrib/rtps/common_types.py 0.00% 2 Missing ⚠️
scapy/contrib/rtps/rtps.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6f0faf3) and HEAD (998851c). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (6f0faf3) HEAD (998851c)
11 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4545       +/-   ##
===========================================
- Coverage   81.61%   49.30%   -32.32%     
===========================================
  Files         356      344       -12     
  Lines       85545    87083     +1538     
===========================================
- Hits        69819    42934    -26885     
- Misses      15726    44149    +28423     
Files with missing lines Coverage Δ
scapy/contrib/rtps/rtps.py 85.71% <0.00%> (-13.11%) ⬇️
scapy/contrib/rtps/common_types.py 58.26% <0.00%> (-37.01%) ⬇️

... and 313 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Splinter1984 Splinter1984 force-pushed the fix_data_packet_pl_len branch from c0193ed to d87ccc8 Compare October 4, 2024 14:54
Take into account size of `inlineQoS`.
@gpotter2 gpotter2 added the bug label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTPS DataPacketField wrong payload len.
2 participants