Skip to content

RFC9686 support added #4694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged

RFC9686 support added #4694

merged 1 commit into from
Apr 21, 2025

Conversation

tomaszmrugalski
Copy link
Contributor

There's RFC9686 that adds address registration mechanism to DHCPv6. It defines two DHCPv6 messages (ADDR-REG-INFORM and ADDR-REG-REPLY) and one DHCPv6 option (ADDR-REG-ENABLE). Covering those is what this PR does.

This includes new UTs. The tests on master currently fail on unrelated changes (test/scapy/layers/dcerpc.uts). So I ran just the DHCPv6 tests (python3 UTscapy.py -t test/scapy/layers/dhcp6.uts -F) and they all passed. This includes several new ones that were added.

This should have no impact on other libs.

Tox/Flake8 says the code is clean.

There are LOTS of pylint warnings in the dhcp6.py file, but AFAICT none related to my new code.

Haven't contributed in ages, so apologies if missed anything. Will gladly update with whatever is needed.

I've squashed the commits.

This adds 2 new DHCPv6 messages and 1 new DHCPv6 option

 - ADDR-REG-INFORM message added
 - ADDR-REG-REPLY message added
 - ADDR-REG option added
 - Flake8 appeased
 - Unit-tests added
Copy link

codecov bot commented Mar 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (a4f958b) to head (aabb0d4).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4694      +/-   ##
==========================================
- Coverage   82.13%   78.59%   -3.54%     
==========================================
  Files         361      336      -25     
  Lines       86830    81636    -5194     
==========================================
- Hits        71319    64164    -7155     
- Misses      15511    17472    +1961     
Files with missing lines Coverage Δ
scapy/layers/dhcp6.py 65.44% <100.00%> (-20.63%) ⬇️

... and 288 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomaszmrugalski
Copy link
Contributor Author

I don't understand the codecov failure.

Couple issues with that report:

  1. It says the global coverage (for all files) went down by 3.54%. That doesn't look right. I added 37 lines of production code. That would imply there's only a bit over 1000 lines of code in the whole Scapy project. That doesn't make sense.

  2. When I expand the details, it says 100% of the patch was covered.

I'm not sure how to proceed. I'm willing to tweak the patch as needed. Please advise.

@gpotter2
Copy link
Member

Not to worry, codecov acts a bit randomly at times.
Thanks for the PR

@gpotter2 gpotter2 closed this Apr 21, 2025
@gpotter2 gpotter2 reopened this Apr 21, 2025
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again for the delay, the CI was borked. Thanks for the PR.

@gpotter2 gpotter2 merged commit 83f8bc4 into secdev:master Apr 21, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants