Skip to content

Bluetooth: Make EIR_AdvertisingInterval variable length #4711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

antoniovazquezblanco
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

This should fix #4625

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.11%. Comparing base (8f9c7a6) to head (0f40f90).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4711   +/-   ##
=======================================
  Coverage   82.11%   82.11%           
=======================================
  Files         361      361           
  Lines       86908    86908           
=======================================
  Hits        71365    71365           
  Misses      15543    15543           
Files with missing lines Coverage Δ
scapy/layers/bluetooth.py 90.39% <ø> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 merged commit 9363bfd into secdev:master Apr 21, 2025
24 checks passed
@gpotter2
Copy link
Member

Thanks for the PR & sorry for the delay !

@antoniovazquezblanco antoniovazquezblanco deleted the advint branch April 22, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluetooth Advertising Interval is variable-length (2, 3, or 4 bytes) in newer specs, not just 2 bytes
2 participants