Skip to content

bluetooth: Add version and company identifiers to local version commands #4716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

antoniovazquezblanco
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

Just adds more information to the HCI_Cmd_Complete_Read_Local_Version_Information packet :)

@antoniovazquezblanco antoniovazquezblanco force-pushed the hcilv branch 3 times, most recently from dc0cb7e to 42dc38e Compare April 8, 2025 18:40
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 39.39394% with 20 lines in your changes missing coverage. Please review.

Project coverage is 49.29%. Comparing base (8ceee51) to head (f26c841).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
scapy/tools/generate_bluetooth.py 0.00% 20 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8ceee51) and HEAD (f26c841). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (8ceee51) HEAD (f26c841)
11 3
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4716       +/-   ##
===========================================
- Coverage   82.15%   49.29%   -32.86%     
===========================================
  Files         361      345       -16     
  Lines       87284    87043      -241     
===========================================
- Hits        71705    42908    -28797     
- Misses      15579    44135    +28556     
Files with missing lines Coverage Δ
scapy/data.py 80.21% <100.00%> (-10.62%) ⬇️
scapy/layers/bluetooth.py 83.83% <100.00%> (-6.68%) ⬇️
scapy/libs/bluetoothids.py 100.00% <100.00%> (ø)
scapy/tools/generate_bluetooth.py 0.00% <0.00%> (ø)

... and 312 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@XenoKovah
Copy link
Contributor

It would probably be good to add a comment pointing to https://bitbucket.org/bluetooth-SIG/public/src/main/assigned_numbers/company_identifiers/company_identifiers.yaml where the company identifiers come from, so they can be more easily updated in the future (since they change very frequently).

@gpotter2
Copy link
Member

gpotter2 commented Apr 21, 2025

Hi, sorry for the delay. I think that this should be moved to someplace else as it makes bluetooth.py a bit unreadable.

Ideally it would be stored similarly to conf.manufdb (50k entries), which is stored as a base85 compressed & cached blob. Although, considering there are only 3k entries here, I guess that storing the dict in data.py would be acceptable. In all cases, for a dict this big, I would avoid putting it in layers/.

How does that sound?

@antoniovazquezblanco
Copy link
Contributor Author

Sorry for the delay. Went the easy route and moved the dict to data. :)

@antoniovazquezblanco
Copy link
Contributor Author

Thanks @gpotter2 for the improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants