Skip to content

[STRATCONN-434] Update Headers for iOS 14 work #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Example/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ PODS:
- OCHamcrest (7.1.2)
- OCMockito (5.1.3):
- OCHamcrest (~> 7.0)
- Segment-Amplitude (3.2.0):
- Amplitude
- Segment-Amplitude (3.2.1):
- Amplitude (~> 7.0.1)
- Analytics
- Specta (1.0.7)

Expand Down Expand Up @@ -35,9 +35,9 @@ SPEC CHECKSUMS:
Expecta: 3b6bd90a64b9a1dcb0b70aa0e10a7f8f631667d5
OCHamcrest: b284c9592c28c1e4025a8542e67ea41a635d0d73
OCMockito: 677cbb4a18fd492b5a4fb10144dada4de5ddb877
Segment-Amplitude: 300e2888691b75b8364389b2c242f6b953932945
Segment-Amplitude: 42876f7adc8544948e876770e8d839b462f3c51b
Specta: 3e1bd89c3517421982dc4d1c992503e48bd5fe66

PODFILE CHECKSUM: a7bf6ef16f54033a66dc8c09524260667af4e881

COCOAPODS: 1.10.0.rc.1
COCOAPODS: 1.9.3
113 changes: 61 additions & 52 deletions Example/Segment-Amplitude.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

16 changes: 9 additions & 7 deletions Example/Segment-Amplitude/Main.storyboard
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="7706" systemVersion="14D136" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" initialViewController="whP-gf-Uak">
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB" version="3.0" toolsVersion="15705" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" colorMatched="YES" initialViewController="whP-gf-Uak">
<device id="retina4_7" orientation="portrait" appearance="light"/>
<dependencies>
<deployment identifier="iOS"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="7703"/>
<deployment version="4352" identifier="iOS"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="15706"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
<scenes>
<!--View Controller-->
Expand All @@ -14,14 +16,14 @@
<viewControllerLayoutGuide type="bottom" id="Mvr-aV-6Um"/>
</layoutGuides>
<view key="view" contentMode="scaleToFill" id="TpU-gO-2f1">
<rect key="frame" x="0.0" y="0.0" width="600" height="600"/>
<rect key="frame" x="0.0" y="0.0" width="375" height="667"/>
<autoresizingMask key="autoresizingMask" widthSizable="YES" heightSizable="YES"/>
<color key="backgroundColor" white="1" alpha="1" colorSpace="calibratedWhite"/>
<color key="backgroundColor" red="1" green="1" blue="1" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
</view>
</viewController>
<placeholder placeholderIdentifier="IBFirstResponder" id="tc2-Qw-aMS" userLabel="First Responder" sceneMemberID="firstResponder"/>
</objects>
<point key="canvasLocation" x="305" y="433"/>
<point key="canvasLocation" x="-14" y="75"/>
</scene>
</scenes>
</document>
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
SDK ?= "iphonesimulator"
DESTINATION ?= "platform=iOS Simulator,name=iPhone 8"
DESTINATION ?= "platform=iOS Simulator,name=iPhone 11"
PROJECT := Segment-Amplitude
XC_ARGS := -scheme $(PROJECT)_Example -workspace Example/$(PROJECT).xcworkspace -sdk $(SDK) -destination $(DESTINATION) ONLY_ACTIVE_ARCH=NO

Expand Down
5 changes: 5 additions & 0 deletions Pod/Classes/SEGAmplitudeIntegration.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
#import <Foundation/Foundation.h>

#if defined(__has_include) && __has_include(<Analytics/Analytics.h>)
#import <Analytics/Analytics.h>
#else
#import <Segment/Analytics.h>
#endif

#if defined(__has_include) && __has_include(<Amplitude_iOS/Amplitude.h>)
#import <Amplitude_iOS/Amplitude.h>
Expand Down
4 changes: 4 additions & 0 deletions Pod/Classes/SEGAmplitudeIntegration.m
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#import "SEGAmplitudeIntegration.h"
#if defined(__has_include) && __has_include(<Analytics/Analytics.h>)
#import <Analytics/Analytics.h>
#else
#import <Segment/Analytics.h>
#endif


@implementation SEGAmplitudeIntegration
Expand Down
6 changes: 5 additions & 1 deletion Pod/Classes/SEGAmplitudeIntegrationFactory.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
#import <Foundation/Foundation.h>
#import <Analytics/Analytics.h>

#if defined(__has_include) && __has_include(<Analytics/Analytics.h>)
#import <Analytics/Analytics.h>
#else
#import <Segment/Analytics.h>
#endif
#import "SEGAmplitudeIntegration.h"


Expand Down
2 changes: 1 addition & 1 deletion Segment-Amplitude.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ Pod::Spec.new do |s|
s.source_files = 'Pod/Classes/**/*'

s.dependency 'Analytics'
s.dependency 'Amplitude'
s.dependency 'Amplitude', '~> 7.0.1'
end