Added convenience methods for ObjC interop #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
May 6, 2022
bsneed
commented
- Added convenience methods for ObjC interop.
- Reduced cellular info example down to just iOS to fix CI issue.
migs647
reviewed
May 6, 2022
| @@ -18,7 +18,10 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| Analytics.main.add(plugin: IDFACollection()) | |||
| Analytics.main.add(plugin: UIKitScreenTracking()) | |||
| Analytics.main.add(plugin: NotificationTracking()) | |||
|
|
|||
| #if os(iOS) && !targetEnvironment(macCatalyst) | |||
| Analytics.main.add(plugin: CellularCarrier()) | |||
migs647
reviewed
May 6, 2022
| @@ -13,12 +13,20 @@ import Foundation | |||
|
|
|||
| @objc(SEGAnalytics) | |||
| public class ObjCAnalytics: NSObject { | |||
| internal let analytics: Analytics | |||
| /// The underlying Analytics object we're working with | |||
| public let analytics: Analytics | |||
There was a problem hiding this comment.
We had to expose this for tests?
There was a problem hiding this comment.
makes cross-config way easier if you can init in objc and then access it later in swift if needed and vice versa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.