-
Notifications
You must be signed in to change notification settings - Fork 96
Additions to enable CLI support #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
5970aac
Adds property to determine if any events are pending being sent.
ebbe3cf
Make public and rename
9202cb1
refactro
accb888
fine tuning
340acaa
additional checks
066de0c
logic fix
a27cf29
optimization
9a621b5
fixed event count set
9cfa8ba
stop bypassing sync queue
8a27b87
fixed optional
a1c3602
added another convenience method
e78bfe4
fix missing file handle
bf60c04
fix missing optional
d36c810
another fix
0b102dc
fixes
f72627a
more fixes
4d70c7e
and another
7c9924a
utility method
dc609d2
docs update
aeffcf1
Merge branch 'main' of github.com:segmentio/analytics-swift into bsne…
916c391
Add screen call to example
f778e2e
Merge branch 'main' into bsneed/cli_additions
355d0c3
Improve error message for path lookup failure.
bsneed 431100f
Fixed cellular carrier path.
bsneed 184c40f
Merge remote-tracking branch 'origin/main' into bsneed/cli_additions
bsneed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bsneed - why this line has been added here when there is another call of this method that happens independently from the result value?
https://github.com/segmentio/analytics-swift/pull/148/files#diff-92679f628b3def3ba245e4435edfcea09ea06a77277e6e2497aa331efbf46028R136
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @grzegorzkrukowski ! The cleanupUploads call here isn't necessary. Fortunately the subsequent call results in a no-op.