Skip to content

Fix unnecessary retains to prevent zombie Analytics instances #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 18, 2022
Merged

Fix unnecessary retains to prevent zombie Analytics instances #164

merged 6 commits into from
Oct 18, 2022

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Oct 17, 2022

  • Fixed a few retain loops.
  • Added tests to capture leaks in the future.
  • Did some cleanup as necessary.

Fixes #159

@bsneed bsneed mentioned this pull request Oct 17, 2022
Closed
@bsneed
Copy link
Contributor Author

bsneed commented Oct 17, 2022

I see I missed some NotificationCenter ones; fixing...

@bsneed bsneed merged commit c2c4398 into main Oct 18, 2022
@bsneed bsneed deleted the bsneed/leak_fixes branch October 18, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelGHSeg MichaelGHSeg MichaelGHSeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zombie Analytics after deallocation.
2 participants
@bsneed @MichaelGHSeg