Removed auth header w/ writekey; Added context.instanceId #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bsneed merged 2 commits into main from bsneed/writekey_consolidation

Dec 7, 2022

Contributor

bsneed commented Dec 5, 2022

Removed auth-header containing writekey.
Added context.instanceId to identify analytics instance.


          Removed auth header w/ writekey; Added context.instanceId

e673036

Contributor

didiergarcia commented Dec 5, 2022

Do we need to make changes to the tests that use Authorization header?:

https://github.com/segmentio/analytics-swift/blob/main/Tests/Segment-Tests/Analytics_Tests.swift#L535

https://github.com/segmentio/analytics-swift/blob/main/Tests/Segment-Tests/StressTests.swift#L52

wenxi-zeng approved these changes

View reviewed changes

Contributor

wenxi-zeng left a comment

LGTM

didiergarcia approved these changes

View reviewed changes


          Fixed test.

05783f7

bsneed merged commit 9cf108a into main

bsneed deleted the bsneed/writekey_consolidation branch

December 7, 2022 23:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet