Fix to append rather than overwrite data in existing files #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgloin
suggested changes
Jan 24, 2023
Comment on lines
56
to
60
| if #available(iOS 13.4, *) { | ||
| _ = try? fileHandle?.seekToEnd() | ||
| } else { | ||
| try? fileHandle?.seek(toOffset: .max) | ||
| } |
There was a problem hiding this comment.
Likely could improve with code for all supported platforms
dmcgloin
approved these changes
Jan 25, 2023
dmcgloin
approved these changes
Jan 26, 2023
|
Thanks for merging, @bsneed. Any idea when a release is targeted with this change? |
|
Just released. Thanks @dmcgloin ! https://github.com/segmentio/analytics-swift/releases/tag/1.3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code will result in malformed JSON being sent to the server because of partial events overwriting the start of existing files. This fix will ensure we always append to a pre-existing file.