Null userId and traits update fixes #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
Mar 7, 2023
bsneed
commented
- Update objc identify method to accept nil userid and allow trait updates.
- Added test
alanjcharles
approved these changes
Mar 7, 2023
didiergarcia
reviewed
Mar 7, 2023
| analytics.identify(userId: userId, traits: traits) | ||
| public func identify(userId: String?, traits: [String: Any]?) { | ||
| if let userId = userId { | ||
| analytics.identify(userId: userId, traits: traits) |
There was a problem hiding this comment.
This looks like a recursive infinite loop?
On line 68: is userId not an Optional anymore? and is there identify() function that doesn't take an optional that this will go to instead?
There was a problem hiding this comment.
This is calling into the swift version of identify where userId is not optional.
didiergarcia
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.