Objective-C API improvements #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,9 @@ import Foundation | |||
| public class ObjCConfiguration: NSObject { | |||
| internal var configuration: Configuration | |||
|
|
|||
| /// Sets a reference to your application. This can be useful in instances | |||
| /// where referring back to your application is necessary, such as within plugins | |||
| /// or async code. The default value is `nil`. | |||
| @objc | |||
| public var application: Any? { | |||
There was a problem hiding this comment.
Any chance this should be a WEAK reference?
There was a problem hiding this comment.
actually, not necessary. it's a pass through and is already held weak.
| case let e as GroupEvent: | ||
| return ObjCGroupEvent(event: e) | ||
| case let e as AliasEvent: | ||
| return ObjCAliasEvent(event: e) |
There was a problem hiding this comment.
Do you have a page event that could go here?
didiergarcia
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.