-
Notifications
You must be signed in to change notification settings - Fork 96
Added operating mode config option & behavior. #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
Nov 16, 2023
- Added operatingMode confi option & logic
- Changed unit-test settings setup to respect operating mode.
- Made some startup plugins not auto-load when in server mode.
- Fixed logging output to be correct.
- Updated testPurgeStorage to reflect new flush behavior.
- Added test for server operation mode.
This was referenced Nov 16, 2023
73e1626
to
1e91157
Compare
didiergarcia
approved these changes
Nov 16, 2023
Sources/Segment/Configuration.swift
Outdated
// MARK: - Operating Mode | ||
/// Specifies the operating mode/context | ||
public enum OperatingMode { | ||
/// Running as an executable on a server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Callout to project README.md to list differences.
alanjcharles
approved these changes
Nov 16, 2023
oscb
reviewed
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.