async writer retries #382
Merged
async writer retries #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achille-roussel
approved these changes
Feb 22, 2020
jnjackins
added a commit
that referenced
this pull request
Jun 15, 2020
This reverts commit bf3be08.
Merged
jnjackins
added a commit
that referenced
this pull request
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an async writer does not retry failed messages – a temporary network connection error will result in lost messages.
This change attempts to improve this situation by retrying messages for both sync and async writers.
In order to implement this, I moved the existing retry loop down the stack to the internal
writertype. I'm fairly sure this will not break the existing behavior of sync writers, but I'd appreciate some extra eyes on this.