fix default fetch.min.bytes to 1, #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

achille-roussel merged 1 commit into segmentio:master from eaglexiang:feature/default_fetch.min.bytes_1

Dec 4, 2020

Contributor

eaglexiang commented Nov 26, 2020

following official document

The default setting of 1 byte means that fetch requests are answered as soon as a single byte of data is available or the fetch request times out waiting for data to arrive. Setting this to something greater than 1 will cause the server to wait for larger amounts of data to accumulate which can improve server throughput a bit at the cost of some additional latency.


          fix default fetch.min.bytes to 1,

34eabf7

following official document.
(https://kafka.apache.org/documentation/#fetch.min.bytes)

eaglexiang mentioned this pull request

wrong default value for ReaderConfig.MinBytes? #434

Closed

achille-roussel self-requested a review

December 4, 2020 19:36

achille-roussel self-assigned this

Contributor

achille-roussel commented Dec 4, 2020

The change looks good, thanks for the fix!

achille-roussel merged commit 1d5a83b into segmentio:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet