Skip to content

set ServerName on tls.Config even when InsecureSkipVeriy is true #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2022
Merged

set ServerName on tls.Config even when InsecureSkipVeriy is true #860

merged 1 commit into from
Mar 7, 2022

Conversation

rhansen2
Copy link
Collaborator

@rhansen2 rhansen2 commented Mar 7, 2022

This behavior also matches the old dialer behavior.

@rhansen2
t ServerName on tls.Config even when InsecureSkipVeriy is true
3a4864e 
This behavior also matches the old dialer behavior.
@rhansen2 rhansen2 changed the title t ServerName on tls.Config even when InsecureSkipVeriy is true set ServerName on tls.Config even when InsecureSkipVeriy is true Mar 7, 2022
@rhansen2 rhansen2 merged commit a9325a2 into main Mar 7, 2022
@rhansen2 rhansen2 deleted the always-set-server-name branch March 7, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achille-roussel achille-roussel achille-roussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhansen2 @achille-roussel