support saslAuthenticate v0 in protocol package #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhansen2
force-pushed
the
transport-saslv0
branch
2 times, most recently
from
983014e to
52c3d81
Compare
|
The differences are documented here: https://kafka.apache.org/protocol#sasl_handshake (although I found the issue by comparing dialer network traffic to transport network traffic >.<) |
|
When do you think you can merge this PR? I wait for it with impatience :) |
achille-roussel
approved these changes
Apr 1, 2022
rhansen2
force-pushed
the
transport-saslv0
branch
from
52c3d81 to
571f05b
Compare
rhansen2
force-pushed
the
transport-saslv0
branch
from
571f05b to
09eb091
Compare
This was referenced Apr 1, 2022
Closed
|
@Jrmy2402 This fix is now included in https://github.com/segmentio/kafka-go/releases/tag/v0.4.31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially related to #868 and #795