curl: override any "-w" options that might exist

[kevinburkesegment]

See the code comment for an explanation.

[achille-roussel]

Using -w would conflict with an existing curl option I believe:

       -w, --write-out <format>
              Make curl display information on stdout after a completed transfer. The format is a string that may contain plain text mixed with any number of variables. The format can be specified as a literal "string", or you can have curl read the format from a file with "@filename"
              and to tell curl to read the format from stdin you write "@-".
...

Do you have another preferred argument?

Alternatively we could use an environment variable to alter the behavior.

[kevinburke]

Sorry that's the goal - I have "-w \n" in my .curlrc because it makes most curl requests format better when printed to stdout. But it breaks pprof files downloaded with curl which is one of the main things you'd be downloading with kubectl-curl.

I guess I could check if stdout is a TTY or not, and only append the "-w" argument if it's not?

[achille-roussel]

🤔 I believe it should work already then? Maybe it didn't because of #10 ?

Have you tried with the latest release?

[kevinburke]

I believe it should work already then?

When you say "it" what do you mean? On master, kubectl-curl reads the contents of .curlrc ("-w \n") and appends a newline, which I don't want it to do, since it breaks pprof file parsing. On this branch, kubectl-curl reads the contents of .curlrc but they are overridden by the argument passed directly here.

[achille-roussel]

What I mean is passing of the -w option should already work? Can you do kubectl curl -w "" ... for example?

I think reading of the .curlrc file is the expected behavior, the goal of this plugin is to run a curl command against a running kubernetes pod, so it should behave the same as it would if the user was executing a curl command against any other http server.