Skip to content

ci: update docker compose and wait for db image #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 5, 2025

Conversation

MichaelShohat
Copy link
Contributor

@MichaelShohat MichaelShohat commented May 5, 2025

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

  • Use docker compose instead of docker-compose due to a newer version of docker on ubuntu-latest runners.
  • Use jwilder/dockerize instead of giorgos/takis to wait for the db to run in the CI process due to an old image format.
  • Format the docker compose command for postgres because it was failing to set locale.gen file

Notes

Upon seeing the following PR that would benefit an issue I'm dealing with #1532 I noticed the CI is broken and trying to fix it.

@MichaelShohat MichaelShohat changed the title fix: ci WIP fix: ci May 5, 2025
@MichaelShohat MichaelShohat changed the title WIP fix: ci fix: ci for pull requests (wait for db, docker compose syntax) May 5, 2025
@WikiRik WikiRik changed the title fix: ci for pull requests (wait for db, docker compose syntax) ci: update docker compose and wait for db image May 5, 2025
@WikiRik WikiRik merged commit c03f20e into sequelize:main May 5, 2025
16 checks passed
Copy link

github-actions bot commented May 5, 2025

🎉 This PR is included in version 6.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants