Skip to content

Add db:info command which returns database configuration #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

reilg
Copy link

@reilg reilg commented Oct 14, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Description of change

I wanted to add a way to quickly check if a command would be performed against the correct database connection.

Add the db:info command.

Outputs:

Config {
  username: 'root',
  password: '***',
  database: 'test_database',
  host: 'localhost',
  port: '3306',
  dialect: 'mysql'
}

This isn't really very polished and no additional tests have been written to cover the command. I mainly wanted to open this PR to get comments and/or suggestions since I'm currently using this version for my current projects.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 25, 2020
@Americas
Copy link
Collaborator

Americas commented Nov 6, 2021

The idea is great! Just make the output a little prettier and add some tests and we can add this.

@stale stale bot removed the stale label Nov 6, 2021
@reilg reilg force-pushed the add-dbinfo-command branch from 06406b3 to 7eee0cc Compare October 5, 2022 12:13
@reilg reilg closed this Oct 5, 2022
@WikiRik WikiRik mentioned this pull request Oct 23, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants