Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

feat(lambda-at-edge): support external rewrites #839

Merged
merged 6 commits into from
Dec 10, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Dec 8, 2020

Fixes: #832

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #839 (dd6a39e) into master (ac28b2a) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
+ Coverage   80.33%   80.55%   +0.21%     
==========================================
  Files          63       63              
  Lines        2217     2242      +25     
  Branches      500      505       +5     
==========================================
+ Hits         1781     1806      +25     
  Misses        376      376              
  Partials       60       60              
Impacted Files Coverage Δ
packages/libs/lambda-at-edge/src/api-handler.ts 88.88% <100.00%> (+0.88%) ⬆️
...ackages/libs/lambda-at-edge/src/default-handler.ts 95.27% <100.00%> (+0.07%) ⬆️
...ckages/libs/lambda-at-edge/src/routing/rewriter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac28b2a...dd6a39e. Read the comment docs.

"host",
"transfer-encoding",
"via",
"content-encoding"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not actually blacklisted but because the data returned is uncompressed (via fetch), copying this header tells CloudFront not to compress content, and then it fails at the browser since it cannot decompress already uncompressed content.

@dphang dphang merged commit d57f75f into master Dec 10, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/external-rewrites branch December 10, 2020 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External URL rewrites
1 participant