Skip to content

Improve JSON Schema compatibility #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve JSON Schema compatibility #1099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/validation/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export module SWSchemaValidator {
const ajv = new Ajv({ strict: false, allowUnionTypes: true });
addFormats(ajv);

const workflowSchemaId = "https://serverlessworkflow.io/schemas/1.0.0/workflow.yaml";
const workflowSchemaId = "https://serverlessworkflow.io/schemas/1.0.1/workflow.yaml";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we merging this as part of the 1.0.1 release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what else is planned for v1.0.1, but since this introduces a schema change, I think we should bump the version. Otherwise, anyone relying on v1.0.0 might be caught off guard when this gets merged.
For example, if @fjtirado wasn’t aware of the change and we published an override of v1.0.0, it could break the Java SDK.

const schemaPath = "../../../schema";
export const defaultEncoding = "utf-8";

Expand Down
2 changes: 1 addition & 1 deletion .ci/validation/test/fixtures/invalid/extra-property-in-call.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: examples
name: two-tasks-in-one-item
version: '0.1.0'
Expand Down
2 changes: 1 addition & 1 deletion .ci/validation/test/fixtures/invalid/listen-any-until-any-until.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: test
name: listen-to-any
version: '0.1.0'
Expand Down
2 changes: 1 addition & 1 deletion .ci/validation/test/fixtures/invalid/two-tasks-in-one-item.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: examples
name: two-tasks-in-one-item
version: '0.1.0'
Expand Down
2 changes: 1 addition & 1 deletion ctk/features/branch.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Feature: Composite Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: fork
version: '1.0.0'
Expand Down
10 changes: 5 additions & 5 deletions ctk/features/call.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Feature: Call Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: http-call-with-content-output
version: '1.0.0'
Expand Down Expand Up @@ -40,7 +40,7 @@ Feature: Call Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: http-call-with-response-output
version: '1.0.0'
Expand Down Expand Up @@ -68,7 +68,7 @@ Feature: Call Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: http-call-with-basic-auth
version: '1.0.0'
Expand Down Expand Up @@ -98,7 +98,7 @@ Feature: Call Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: openapi-call-with-content-output
version: '1.0.0'
Expand Down Expand Up @@ -127,7 +127,7 @@ Feature: Call Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: openapi-call-with-response-output
version: '1.0.0'
Expand Down
6 changes: 3 additions & 3 deletions ctk/features/data-flow.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Feature: Data Flow
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: output-filtering
version: '1.0.0'
Expand Down Expand Up @@ -36,7 +36,7 @@ Feature: Data Flow
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: output-filtering
version: '1.0.0'
Expand Down Expand Up @@ -65,7 +65,7 @@ Feature: Data Flow
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: non-object-output
version: '1.0.0'
Expand Down
2 changes: 1 addition & 1 deletion ctk/features/do.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Feature: Composite Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: do
version: '1.0.0'
Expand Down
2 changes: 1 addition & 1 deletion ctk/features/emit.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Feature: Emit Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: emit
version: '1.0.0'
Expand Down
4 changes: 2 additions & 2 deletions ctk/features/flow.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Feature: Flow Directive
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: implicit-sequence
version: '1.0.0'
Expand Down Expand Up @@ -35,7 +35,7 @@ Feature: Flow Directive
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: explicit-sequence
version: '1.0.0'
Expand Down
2 changes: 1 addition & 1 deletion ctk/features/for.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Feature: For Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: for
version: '1.0.0'
Expand Down
2 changes: 1 addition & 1 deletion ctk/features/raise.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Feature: Raise Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: raise-custom-error
version: '1.0.0'
Expand Down
2 changes: 1 addition & 1 deletion ctk/features/set.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Feature: Set Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: set
version: '1.0.0'
Expand Down
6 changes: 3 additions & 3 deletions ctk/features/switch.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Feature: Switch Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: switch-match
version: '1.0.0'
Expand Down Expand Up @@ -52,7 +52,7 @@ Feature: Switch Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: switch-default-implicit
version: '1.0.0'
Expand Down Expand Up @@ -95,7 +95,7 @@ Feature: Switch Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: switch-default-implicit
version: '1.0.0'
Expand Down
4 changes: 2 additions & 2 deletions ctk/features/try.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Feature: Try Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: try-catch-404
version: '1.0.0'
Expand Down Expand Up @@ -55,7 +55,7 @@ Feature: Try Task
Given a workflow with definition:
"""yaml
document:
dsl: '1.0.0'
dsl: '1.0.1'
namespace: default
name: try-catch-503
version: '1.0.0'
Expand Down
Loading