-
Notifications
You must be signed in to change notification settings - Fork 39
Use of correction authentication properties #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of correction authentication properties #343
Conversation
…eme Changed Signed-off-by: Jaliya Udagedara <[email protected]>
Signed-off-by: Jaliya Udagedara <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cheers!
@JBBianchi Please review the Blazor code => indentation |
@jaliyaudagedara I'm not a big fan of Visual Studio default formatting for Razor code. I'd rather use a more "logical" approach with indentation for each block, like you would do in normal C# code when you open a block. An alternative version/additional guideline would be: "if an element attribute goes to a new line, the all attributes should be on a separated line". e.g.: <input type="text" value="@authentication.Name" required placeholder="Name" title="The authentication name" class="form-control"
@onchange="async e => await OnPropertyChangedAsync(nameof(authentication.Name), a => a.Name = (string)e.Value!)" /> vs <input
type="text"
value="@authentication.Name"
required
placeholder="Name"
title="The authentication name"
class="form-control"
@onchange="async e => await OnPropertyChangedAsync(nameof(authentication.Name), a => a.Name = (string)e.Value!)"
/> Both are illustrated here: https://gist.github.com/JBBianchi/0cb212d3e93191fd267fd5a20ac1f206 |
Signed-off-by: Jaliya Udagedara <[email protected]>
I am sorry, it makes sense, pushed a change. and on,
definitely agree! |
Don't be sorry, thanks for your contribution :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Many thanks ❤️
Fix for sub-issue mentioned in #342
The first commit contains the fix, and the second commit is just formatting.