Skip to content

Use of correction authentication properties #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Use of correction authentication properties #343

merged 3 commits into from
Mar 24, 2023

Conversation

jaliyaudagedara
Copy link
Contributor

@jaliyaudagedara jaliyaudagedara commented Mar 12, 2023

Fix for sub-issue mentioned in #342

The first commit contains the fix, and the second commit is just formatting.

@jaliyaudagedara jaliyaudagedara marked this pull request as ready for review March 12, 2023 00:48
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers!

@cdavernas
Copy link
Member

@JBBianchi Please review the Blazor code => indentation

@JBBianchi
Copy link
Member

@jaliyaudagedara I'm not a big fan of Visual Studio default formatting for Razor code.

I'd rather use a more "logical" approach with indentation for each block, like you would do in normal C# code when you open a block.

An alternative version/additional guideline would be: "if an element attribute goes to a new line, the all attributes should be on a separated line". e.g.:

<input type="text" value="@authentication.Name" required placeholder="Name" title="The authentication name" class="form-control"
    @onchange="async e => await OnPropertyChangedAsync(nameof(authentication.Name), a => a.Name = (string)e.Value!)" />

vs

<input 
    type="text" 
    value="@authentication.Name" 
    required 
    placeholder="Name" 
    title="The authentication name" 
    class="form-control"
    @onchange="async e => await OnPropertyChangedAsync(nameof(authentication.Name), a => a.Name = (string)e.Value!)"
/>

Both are illustrated here: https://gist.github.com/JBBianchi/0cb212d3e93191fd267fd5a20ac1f206

Signed-off-by: Jaliya Udagedara <[email protected]>
@jaliyaudagedara
Copy link
Contributor Author

jaliyaudagedara commented Mar 22, 2023

@JBBianchi,

I am sorry, it makes sense, pushed a change.

and on,

"if an element attribute goes to a new line, then all attributes should be on a separated line".

definitely agree!

@JBBianchi
Copy link
Member

@JBBianchi,

I am sorry, it makes sense, pushed a change.

and on,

"if an element attribute goes to a new line, then all attributes should be on a separated line".

definitely agree!

Don't be sorry, thanks for your contribution :)

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Many thanks ❤️

@cdavernas cdavernas merged commit bb4d95b into serverlessworkflow:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants