Use python2 for the build whenever possible and bump the version. #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If python2 seems to be a valid Python 2 interpreter, the configure script will use it. Otherwise, it will fall back to python, as previously. We also bump the crate version so that this change can be propagated further the dependency tree. Closes servo#129.
|
@bors-servo r+ |
|
📌 Commit 53a632f has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 26, 2018
Use python2 for the build whenever possible and bump the version. If python2 seems to be a valid Python 2 interpreter, the configure script will use it. Otherwise, it will fall back to python, as previously. We also bump the crate version so that this change can be propagated further the dependency tree. Closes #129. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/132) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
marmistrz
added a commit
to marmistrz/rust-mozjs
that referenced
this pull request
Mar 1, 2018
bors-servo
pushed a commit
to servo/rust-mozjs
that referenced
this pull request
Mar 1, 2018
Bump the versions to propagate servo/mozjs#132 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/392) <!-- Reviewable:end -->
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Mar 7, 2018
Update mozjs_sys Pick up servo/mozjs#132 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20232) <!-- Reviewable:end -->
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 8, 2018
Pick up servo/mozjs#132 Source-Repo: https://github.com/servo/servo Source-Revision: 72d09202f4e5207cee606e122729dd007e6b5ac8 --HG-- extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : adc5d3dd7e14186227285981b3f8c74158cfbafd
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
Pick up servo/mozjs#132 Source-Repo: https://github.com/servo/servo Source-Revision: 72d09202f4e5207cee606e122729dd007e6b5ac8 UltraBlame original commit: 2ace79cd8e52c1937fc45ef7167faff376fb2ad5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
Pick up servo/mozjs#132 Source-Repo: https://github.com/servo/servo Source-Revision: 72d09202f4e5207cee606e122729dd007e6b5ac8 UltraBlame original commit: 2ace79cd8e52c1937fc45ef7167faff376fb2ad5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
Pick up servo/mozjs#132 Source-Repo: https://github.com/servo/servo Source-Revision: 72d09202f4e5207cee606e122729dd007e6b5ac8 UltraBlame original commit: 2ace79cd8e52c1937fc45ef7167faff376fb2ad5
bhearsum
pushed a commit
to mozilla-releng/staging-firefox
that referenced
this pull request
May 1, 2025
Pick up servo/mozjs#132 Source-Repo: https://github.com/servo/servo Source-Revision: 72d09202f4e5207cee606e122729dd007e6b5ac8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If python2 seems to be a valid Python 2 interpreter, the configure
script will use it. Otherwise, it will fall back to python, as
previously.
We also bump the crate version so that this change can be propagated
further the dependency tree.
Closes #129.
This change is