Skip to content

"https://../foo" should not lose the dots when parsed #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Manishearth opened this issue Dec 17, 2016 · 1 comment
Closed

"https://../foo" should not lose the dots when parsed #255

Manishearth opened this issue Dec 17, 2016 · 1 comment
Milestone
rust-url oxidation

Comments

@Manishearth
Copy link
Member

Parsing "https://../foo" gets us "https:///foo". This doesn't seem correct, and no browser has this behavior (they all produce "https://../foo")

cc @SimonSapin
@Manishearth Manishearth added this to the rust-url oxidation milestone Dec 17, 2016
@Manishearth Manishearth mentioned this issue Dec 18, 2016
Closed
Manishearth added a commit to Manishearth/rust-url that referenced this issue Dec 18, 2016
@Manishearth
Handle empty domain segments correctly in idna (fixes servo#255)
37ff338 
Spec asks us to "Otherwise join the labels using U+002E FULL STOP as a
separator". The current code checking if the result was non-empty would
fail if the segments themself were non-empty. It should be equivalent to
`.split('.').map(.. processing ..).join('.')`. Implementing it
procedurally since the code is already pretty procedural.
@SimonSapin
Copy link
Member

This is #171.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rust-url oxidation
Development

Successfully merging a pull request may close this issue.

Handle empty domain segments correctly in idna Manishearth/rust-url
2 participants
@SimonSapin @Manishearth